Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helper methods to update HVAC schedules #1301

Merged
merged 6 commits into from
Aug 29, 2024
Merged

Add helper methods to update HVAC schedules #1301

merged 6 commits into from
Aug 29, 2024

Conversation

vhkristof
Copy link
Contributor

I added the ability to update the hvac schedule similar to how charge schedules are updated.

epenet
epenet reviewed Aug 27, 2024
View reviewed changes
src/renault_api/kamereon/helpers.py Outdated Show resolved Hide resolved
src/renault_api/kamereon/helpers.py Outdated Show resolved Hide resolved
@epenet epenet added enhancement New feature or request breaking labels Aug 28, 2024
@epenet epenet changed the title Update HVAC schedule Add ability to update HVAC schedules Aug 28, 2024
@vhkristof
Copy link
Contributor Author

Is there anything else I should do ?

@epenet epenet mentioned this pull request Aug 29, 2024
Merged
@epenet epenet removed the breaking label Aug 29, 2024
@epenet epenet changed the title Add ability to update HVAC schedules Add helper methods to update HVAC schedules Aug 29, 2024
@epenet epenet merged commit a30fd30 into hacf-fr:main Aug 29, 2024
21 checks passed
@epenet
Copy link
Collaborator

epenet commented Aug 29, 2024

Is there anything else I should do ?

I split the PR, to have the breaking change/deprecation in one, and keep the new feature separate.
Both have been merged now.
Do you need me to publish a release?

@vhkristof
Copy link
Contributor Author

Thanks !
Yes, would be great if you could publish a new release. That way I can continue with updating the integration in Home Assistant.

@epenet
Copy link
Collaborator

epenet commented Aug 29, 2024

Thanks ! Yes, would be great if you could publish a new release. That way I can continue with updating the integration in Home Assistant.

v0.2.7 published
If you plan to update HA, please do a first PR for the dependency bump only (with fixes for the deprecation + plug state) and a follow-up PR later for the new features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epenet epenet epenet approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vhkristof @epenet