Add schedule API and refactor info/config/stat apis in DownloadStation #3
Conversation
There was a problem hiding this comment.
Hi @sylvaindd,
thanks for contributing 👍
Please rebase your branch to the current master and furthermore add a description to this PR, what does it do, what does it add.
Last but not least, please take care of the commits below.
regards,
Michael
| - repo: https:/pre-commit/mirrors-prettier | ||
| rev: v2.2.0 |
There was a problem hiding this comment.
please rebase to current master branch
| """Return schedule configuration about the Download Station instance.""" | ||
| return self._schedule_config | ||
|
|
||
| def set_schedule_config(self, enabled: bool = None, emule_enabled: bool = None): |
| @@ -32,17 +37,50 @@ def update(self): | |||
| self._tasks_by_id[task_data["id"]] = SynoDownloadTask(task_data) | |||
|
|
|||
| # Global | |||
| def update_info(self): | |||
There was a problem hiding this comment.
what is the intention of this dedicated update method?
Those the user is forced to do an manually initial update before info can be accessed
| return self._dsm.get(self.INFO_API_KEY, "GetInfo") | ||
| return self._info | ||
|
|
||
| def update_config(self): |
There was a problem hiding this comment.
what is the intention of this dedicated update method?
Those the user is forced to do an manually initial update before config data can be accessed
|
|
||
| def update_config(self): | ||
| """Update configuration about the Download Station instance.""" | ||
| self._config = self._dsm.get(self.INFO_API_KEY, "GetConfig")["data"] |
There was a problem hiding this comment.
- this could cause KeyError, in case _dsm.get() was unsuccessful
- prior result was not restricted to content of
data
| def update_schedule_config(self): | ||
| """Update schedule configuration about the Download Station instance.""" | ||
| self._schedule_config = self._dsm.get(self.SCHEDULE_API_KEY, "GetConfig")[ | ||
| "data" |
There was a problem hiding this comment.
this could cause KeyError, in case _dsm.get() was unsuccessful
| return self._dsm.get(self.INFO_API_KEY, "GetConfig") | ||
| return self._config | ||
|
|
||
| def update_schedule_config(self): |
There was a problem hiding this comment.
what is the intention of this dedicated update method?
Those the user is forced to do an manually initial update before schedule config data can be accessed
| # set_schedule_config(self, enabled: bool = None, emule_enabled: bool = None) | ||
| api.download_station.set_schedule_config(True, False) |
There was a problem hiding this comment.
| # set_schedule_config(self, enabled: bool = None, emule_enabled: bool = None) | |
| api.download_station.set_schedule_config(True, False) | |
| api.download_station.set_schedule_config(enabled=True, emule_enabled=False) |
| self.update_schedule_config() | ||
| return res | ||
|
|
||
| def update_stat(self): |
There was a problem hiding this comment.
what is the intention of this dedicated update method?
Those the user is forced to do an manually initial update before stat data can be accessed
|
|
||
| def update_stat(self): | ||
| """Update statistic about the Download Station instance.""" | ||
| self._stat = self._dsm.get(self.STAT_API_KEY, "GetInfo")["data"] |
There was a problem hiding this comment.
- this could cause KeyError, in case _dsm.get() was unsuccessful
- prior result was not restricted to content of
data
No description provided.