Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CFW Check before Get Started #2504

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AdRoz78
Copy link

@AdRoz78 AdRoz78 commented Oct 13, 2024

Adding CFW Check before Getting Started, as many people skipped the CFW Check paragraph.

Copy link
Contributor

@Gruetzig Gruetzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR happens to completely remove key information from the guide path.
Solution: Revert the changes in index and link from Key Information to Checking for CFW instead.

@AdRoz78 AdRoz78 marked this pull request as draft October 13, 2024 15:35
@AdRoz78 AdRoz78 marked this pull request as ready for review October 13, 2024 15:38
@AdRoz78
Copy link
Author

AdRoz78 commented Oct 13, 2024

Changed, was just a typo

@lifehackerhansol
Copy link
Contributor

If we are doing this, it should be added to the sidebar.

Check docs/.viteprese/i18n/en_US.js

@@ -6,29 +6,12 @@ head: [
]
---

# Get Started
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This header should not be removed, it is the title of the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants