Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to update to hadolint 2.4.0? #31

Closed
mloskot opened this issue May 7, 2021 · 2 comments · Fixed by #32
Closed

How to update to hadolint 2.4.0? #31

mloskot opened this issue May 7, 2021 · 2 comments · Fixed by #32

Comments

@mloskot
Copy link

mloskot commented May 7, 2021 •
edited
Loading

I hope it's OK to ask questions via GitHub, couldn't find an alternative channel.

The hadolint 2.4.0 now supports the language-docker 10.0.0 with

  • Fixed parsing of dockerfiles including a custom escape char

By the way, thank you @lorenzo and @m-ildefons very much for fixing this!

Would it be possible to update the action to use those latest?
@lorenzo
Copy link
Member

lorenzo commented May 7, 2021

the action code needs to be updated, I won't have time this weekend to fix it, but I'd gladly accept a PR if you want to help

m-ildefons added a commit to m-ildefons/hadolint-action that referenced this issue May 8, 2021
@m-ildefons
hadolint: version bump to 2.4.0
110e47c 
- bump Hadolint version to 2.4.0
- change to debian based image
- add common config options
- expand integration tests for new options

fixes: hadolint#5
fixes: hadolint#8
fixes: hadolint#17
fixes: hadolint#18
fixes: hadolint#31
@m-ildefons m-ildefons mentioned this issue May 8, 2021
Merged
@mloskot
Copy link
Author

mloskot commented May 8, 2021 •
edited
Loading

I thought it needs rebuild of Docker image.
Thank you @m-ildefons for your help with the update, namely, the #32 PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

hadolint: version bump to 2.4.0 m-ildefons/hadolint-action
2 participants
@lorenzo @mloskot