Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic theme change #1061

Closed
valotas opened this issue Nov 23, 2014 · 1 comment
Closed

Dynamic theme change #1061

valotas opened this issue Nov 23, 2014 · 1 comment

Comments

@valotas
Copy link

valotas commented Nov 23, 2014

As I see the current theme mechanism does not do anything else other than using the right css file. But even this is kinda broken as I can not really change the Reveal's theme property without reinitializing the presentation. Is there a reason to support this all together? I brings more confusion IMHO.

Is there something that I am missing? If not, I would suggest to either provide a way to have truly dynamic themes or just drop the thing altogether.
hakimel added a commit that referenced this issue Dec 18, 2014
@hakimel
remove theme config option #1061
7c03d60
@hakimel
Copy link
Owner

hakimel commented Dec 18, 2014

The theme config value was only there so that the themes could be shown in the demo presentation. It was intentionally left out of the README to avoid having it be used by anyone else.

I agree that it would be better to drop it completely so I just did in 7c03d60. The only downside is the demo presentation using a slightly more hacky way to preview the different themes.

@hakimel hakimel closed this as completed Dec 18, 2014
@neuralyzer neuralyzer mentioned this issue Jan 27, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@valotas @hakimel