Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fragment autoslide not working for section containing <audio> element #1170

Closed
bailz opened this issue Mar 18, 2015 · 1 comment
Closed

Fragment autoslide not working for section containing <audio> element #1170

bailz opened this issue Mar 18, 2015 · 1 comment

Comments

@bailz
Copy link

bailz commented Mar 18, 2015

It appears there is an issue with fragments containing data-autoslide and audio elements.

This example works

<section data-autoslide="2000"> 
<ul>
    <li class="fragment" data-autoslide="2000">1</li>
    <li class="fragment" data-autoslide="2000">2</li>
    <li class="fragment" data-autoslide="2000">3</li>
</ul>
</section>

This example does not work

<section data-autoslide="2000"> 
<audio data-autoplay src="testfile.mp3"></audio>
<ul>
    <li class="fragment" data-autoslide="2000">1</li>
    <li class="fragment" data-autoslide="2000">2</li>
    <li class="fragment" data-autoslide="2000">3</li>
</ul>
</section>

Any help would be greatful
Thank you

@bailz bailz changed the title Fragment autoslide only working for first item in a list Fragment autoslide not working for section containing <audio element Mar 18, 2015
@bailz bailz changed the title Fragment autoslide not working for section containing <audio element Fragment autoslide not working for section containing <audio> element Mar 18, 2015
hakimel added a commit that referenced this issue Mar 25, 2015
@hakimel
Copy link
Owner

hakimel commented Mar 25, 2015

This has been fixed. If reveal.js finds "data-autoplay"-enabled media on a slide it automatically sets the auto-slide duration to match the length of the media. This logic has now been disabled when there are fragments in the slide.

@hakimel hakimel closed this as completed Mar 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants