Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Integer and Float values comparable for Join #737

Closed
JohannaOtt opened this issue May 9, 2019 · 4 comments
Closed

Make Integer and Float values comparable for Join #737

JohannaOtt opened this issue May 9, 2019 · 4 comments
Assignees
@florianesser @JohannaOtt
Labels
core enhancement project
Milestone
4.0.0

Comments

@JohannaOtt
Copy link
Contributor

JohannaOtt commented May 9, 2019 •
edited
Loading

In a customer's project, a Join is needed that is based on an attribute with an Integer value in one of the feature types and on an attribute with a Float value in the other one.
The Float version of it holds the same values as the Integer one but ".0" is added.
In order to make the two attributes comparable, one idea was to cut the post-comma part of each Float used for a Join (as a Join using two Float values won't appear anyway) and convert it into Integer.
In this case, there should be an information somewhere that Float values can't be used as Join attributes in order to avoid wrong usage of the Join function.
Alternatively, "cutting" Float values to Integer values could be added as option.

The customer affected wants to use this functionality in an automated workflow so that it should also be deployed in a new hale-cli version.
@JohannaOtt JohannaOtt added this to the 4.0.0 milestone May 9, 2019
@florianesser florianesser self-assigned this Jun 6, 2019
florianesser added a commit to florianesser/hale that referenced this issue Jun 13, 2019
@florianesser
feat(cst): support joins of float and integer properties
e962b60 
This patch adds the same behaviour to the processing of double and
float values that already existed for BigDecimals. In particular,
double and float values that are in fact integers (e.g. `2.0`) are
now serialized without the trailing `.0` during value processing.

This allows the mixed use of float/double and integer/string properties
in Joins.

halestudio#737
@florianesser florianesser mentioned this issue Jun 13, 2019
Merged
florianesser added a commit that referenced this issue Jun 14, 2019
@florianesser
feat(cst): support joins of float and integer properties (#744)
c754eb3 
This patch adds the same behaviour to the processing of double and
float values that already existed for BigDecimals. In particular,
double and float values that are in fact integers (e.g. `2.0`) are
now serialized without the trailing `.0` during value processing.

This allows the mixed use of float/double and integer/string properties
in Joins.

#737
@thorsten-reitz
Copy link
Member

@florianesser isn't this done or at least ready to be challenged?

@florianesser
Copy link
Member

florianesser commented Jul 12, 2019 •
edited
Loading

@thorsten-reitz Yes, it's been merged and can be tested with this build.

@florianesser
Copy link
Member

@JohannaOtt Could you use this successfully in your customer project?

@JohannaOtt
Copy link
Contributor Author

I found an email from June 19th in which the customer confirms, the Join worked with build 15. So I assume this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@florianesser florianesser

@JohannaOtt JohannaOtt

Labels
core enhancement project
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
3 participants
@florianesser @thorsten-reitz @JohannaOtt