Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove whitespace from pos when importing gml geometries #808

Closed
JohannaOtt opened this issue Apr 16, 2020 · 1 comment
Closed

Remove whitespace from pos when importing gml geometries #808

JohannaOtt opened this issue Apr 16, 2020 · 1 comment
Assignees
@florianesser
Labels
bug io
Milestone
4.0.0

Comments

@JohannaOtt
Copy link
Contributor

If source data contains geometries with pos elements structured in the following way (coordinates are provided in their own line)
grafik
hale studio reads the geometry as a 3D geometry with the first value being null:
grafik

When changing the structure in a way that the pos value is in the same line as its tags
grafik it is correctly recognised:
grafik

There is test data available on that (test data for XPlanung 5.1 vollvektoriell FNP) in the relevant GitHub repository.
@florianesser florianesser self-assigned this Apr 30, 2020
@florianesser florianesser added this to the 4.0.0 milestone Apr 30, 2020
florianesser added a commit to florianesser/hale that referenced this issue Apr 30, 2020
@florianesser
fix(io): List binding: trim whitespace before splitting
68792f2 
Make sure that leading and trailing whitespace is removed before splitting
the value of an element bound to `java.util.List` at whitespace.

The old behaviour lead to three list entries (an empty one followed by the one
for each of the actual values) being created for the `pos` element value from
the following snippet:

```
	<gml:Point srsName="EPSG:25832" gml:id="GML-f">
		<gml:pos>
			540465.8278 5802259.4572
		</gml:pos>
	</gml:Point>
```

However, the snippet above should have the same semantics as

```
	<gml:Point srsName="EPSG:25832" gml:id="GML-f">
		<gml:pos>540465.8278 5802259.4572</gml:pos>
	</gml:Point>
```

Therefore, leading and trailing whitespace is now removed before the split.

halestudio#808
@florianesser florianesser mentioned this issue Apr 30, 2020
Merged
florianesser added a commit that referenced this issue Apr 30, 2020
@florianesser
fix(io): List binding: trim whitespace before splitting
06136ec 
Make sure that leading and trailing whitespace is removed before splitting
the value of an element bound to `java.util.List` at whitespace.

The old behaviour lead to three list entries (an empty one followed by the one
for each of the actual values) being created for the `pos` element value from
the following snippet:

```
	<gml:Point srsName="EPSG:25832" gml:id="GML-f">
		<gml:pos>
			540465.8278 5802259.4572
		</gml:pos>
	</gml:Point>
```

However, the snippet above should have the same semantics as

```
	<gml:Point srsName="EPSG:25832" gml:id="GML-f">
		<gml:pos>540465.8278 5802259.4572</gml:pos>
	</gml:Point>
```

Therefore, leading and trailing whitespace is now removed before the split.

#808
@thorsten-reitz
Copy link
Member

LGTM, tested with build https://builds.wetransform.to/job/hale/job/hale~publish(master)/504/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@florianesser florianesser

Labels
bug io
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
3 participants
@florianesser @thorsten-reitz @JohannaOtt