Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate why GML Dictionary code lists are not loaded properly #824

Closed
thorsten-reitz opened this issue Jun 19, 2020 · 0 comments · Fixed by #826
Closed

Investigate why GML Dictionary code lists are not loaded properly #824

thorsten-reitz opened this issue Jun 19, 2020 · 0 comments · Fixed by #826
Assignees
@stempler @florianesser
Labels
project
Milestone
4.0.0

Comments

@thorsten-reitz
Copy link
Member

Loading a codelist like http://spec.tn-its.eu/codelists/RoadFeatureSourceCode.xml seems to suceed, but after assigning the codelist to a href property, the dropdown doesn't populate. Also, when inserting the values manually, the validator complains about these values.

The codelist above does not contain name elements, so I added them through a small transformation project, resulting in entries like this one:

<gml:dictionaryEntry>
    <gml:Definition gml:id="pedestrianCrossing">
      <gml:description>A specified part of a road where pedestrians have right of way to cross</gml:description>
      <gml:identifier codeSpace="http://spec.tn-its.eu/codelists/RoadFeatureTypeCode">pedestrianCrossing</gml:identifier>
      <gml:name codeSpace="http://spec.tn-its.eu/codelists/RoadFeatureTypeCode">pedestrianCrossing</gml:name>
    </gml:Definition>
</gml:dictionaryEntry>

However, even with this codelist, the behaviour doesn't change.
stempler added a commit to stempler/hale that referenced this issue Jun 19, 2020
@stempler
fix: support codes w/o name in GML dictionaries
ac270bd 
If a code definition is found in a GML dictionary w/o a name, the
identifier is used as a fall-back name.

fixes halestudio#824
@stempler stempler mentioned this issue Jun 19, 2020
Merged
thorsten-reitz pushed a commit that referenced this issue Jun 19, 2020
@stempler @thorsten-reitz
fix: support codes w/o name in GML dictionaries
2296579 
If a code definition is found in a GML dictionary w/o a name, the
identifier is used as a fall-back name.

fixes #824
@thorsten-reitz thorsten-reitz added this to the 4.0.0 milestone Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stempler stempler

@florianesser florianesser

Labels
project
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

fix: support codes w/o name in GML dictionaries stempler/hale
3 participants
@stempler @florianesser @thorsten-reitz