Upgrade to quantile function arising from pandas 1.3.0 internals change #170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failing tests in #153, #162, #163, #167, and #168 appear to be a result of problems in pandas itself, introduced in pandas 1.3.0.
Setting pandas requirements to
pandas<1.3.0
to test this hypothesis.EDIT: Confirmed, setting
pandas<1.3.0
let's tests pass (once conda CI got fixed).The problem in the failing tests turns out, that pandas
quantile
is calling itself with the kwargsaxis
,numeric_only
andinterpolation
. However anesthetic's inheritedWeightedDataFrame
overwrites that method without allowing for all these kwargs. In the self call this then results in a TypeError.This is pandas
quantile
method calling itself:This is the TypeError thrown by pytest:
Adding
**kwargs
to anestheticsquantile
function solves this issue (see c174ef0).Checklist:
flake8 anesthetic tests
)pydocstyle --convention=numpy anesthetic
)python -m pytest
)