Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with plot labels #218

Merged
merged 4 commits into from
Aug 16, 2022
Merged

Issue with plot labels #218

merged 4 commits into from
Aug 16, 2022

Conversation

williamjameshandley
Copy link
Collaborator

Description

#207 introduced a bug whereby samples.plot_2d(...) no longer has the correct tex in all of the labels. This arises because samples.plot(...) defaults to using the column label, which can overwrite the labels set up by make_2d_axes. This fixes that by passing xlabel explicitly through samples.plot in samples.plot_2d(...)

Checklist:

  • I have performed a self-review of my own code
  • My code is PEP8 compliant (flake8 anesthetic tests)
  • My code contains compliant docstrings (pydocstyle --convention=numpy anesthetic)
  • New and existing unit tests pass locally with my changes (python -m pytest)
  • I have added tests that prove my fix is effective or that my feature works

@williamjameshandley williamjameshandley added the bug Something isn't working label Aug 15, 2022
@williamjameshandley williamjameshandley added this to the 2.0.0 milestone Aug 15, 2022
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #218 (0a1b54c) into master (46a716d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
+ Coverage   96.61%   96.62%   +0.01%     
==========================================
  Files          25       25              
  Lines        1947     1954       +7     
==========================================
+ Hits         1881     1888       +7     
  Misses         66       66              
Impacted Files Coverage Δ
anesthetic/samples.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@lukashergt lukashergt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice quick bug catch.

@williamjameshandley williamjameshandley merged commit 63f7557 into master Aug 16, 2022
@williamjameshandley williamjameshandley deleted the labels_bug branch August 16, 2022 06:52
@williamjameshandley williamjameshandley restored the labels_bug branch August 16, 2022 06:52
@williamjameshandley williamjameshandley deleted the labels_bug branch August 16, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants