Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename [extras] optional dependency to [all] #281

Merged
merged 7 commits into from
Apr 11, 2023

Conversation

AdamOrmondroyd
Copy link
Collaborator

@AdamOrmondroyd AdamOrmondroyd commented Apr 9, 2023

Description

Quick one, I find it quite strange we have plural extras but singular test optional dependencies, so I've changed it to tests

To match pandas, rename the optional [extras] requirement to [all].

Checklist:

  • I have performed a self-review of my own code
  • My code is PEP8 compliant (flake8 anesthetic tests)
  • My code contains compliant docstrings (pydocstyle --convention=numpy anesthetic)
  • New and existing unit tests pass locally with my changes (python -m pytest)
  • I have added tests that prove my fix is effective or that my feature works
  • I have appropriately incremented the semantic version number in both README.rst and anesthetic/_version.py

@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ca4e0b2) 100.00% compared to head (29ab7a2) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #281   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines         2643      2643           
=========================================
  Hits          2643      2643           
Impacted Files Coverage Δ
anesthetic/_version.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@williamjameshandley williamjameshandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency is important -- I guess the question is whether this should be 'test, extra' or 'tests, extras'. Going by pandas, we should use test, and perhaps all rather than extras

@williamjameshandley williamjameshandley added this to the 2.0.0 milestone Apr 10, 2023
@AdamOrmondroyd AdamOrmondroyd changed the title rename [test] optional dependency to [tests] rename [extras] optional dependency to [all] Apr 11, 2023
@AdamOrmondroyd
Copy link
Collaborator Author

Ah, I'd misremembered that pandas used [tests]. Now swapped around to use [all]

@AdamOrmondroyd AdamOrmondroyd merged commit 08905f4 into handley-lab:master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants