Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api34 for version 3.x #549

Merged
merged 23 commits into from
Jan 17, 2024
Merged

api34 for version 3.x #549

merged 23 commits into from
Jan 17, 2024

Conversation

hannesa2
Copy link
Owner

No description provided.

hannesa2 and others added 17 commits January 17, 2024 08:06
Bumps [org.jetbrains.kotlinx:kotlinx-coroutines-core](https:/Kotlin/kotlinx.coroutines) from 1.6.4 to 1.7.1.
- [Release notes](https:/Kotlin/kotlinx.coroutines/releases)
- [Changelog](https:/Kotlin/kotlinx.coroutines/blob/master/CHANGES.md)
- [Commits](Kotlin/kotlinx.coroutines@1.6.4...1.7.1)

---
updated-dependencies:
- dependency-name: org.jetbrains.kotlinx:kotlinx-coroutines-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [com.google.android.material:material](https:/material-components/material-components-android) from 1.8.0 to 1.9.0.
- [Release notes](https:/material-components/material-components-android/releases)
- [Commits](material-components/material-components-android@1.8.0...1.9.0)

---
updated-dependencies:
- dependency-name: com.google.android.material:material
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [org.jetbrains.kotlinx:kotlinx-coroutines-android](https:/Kotlin/kotlinx.coroutines) from 1.6.4 to 1.7.1.
- [Release notes](https:/Kotlin/kotlinx.coroutines/releases)
- [Changelog](https:/Kotlin/kotlinx.coroutines/blob/master/CHANGES.md)
- [Commits](Kotlin/kotlinx.coroutines@1.6.4...1.7.1)

---
updated-dependencies:
- dependency-name: org.jetbrains.kotlinx:kotlinx-coroutines-android
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
---
updated-dependencies:
- dependency-name: org.jlleitschuh.gradle:ktlint-gradle
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps `kotlin_version` from 1.8.20 to 1.8.22.

Updates `org.jetbrains.kotlin:kotlin-gradle-plugin` from 1.8.20 to 1.8.22
- [Release notes](https:/JetBrains/kotlin/releases)
- [Changelog](https:/JetBrains/kotlin/blob/v1.8.22/ChangeLog.md)
- [Commits](JetBrains/kotlin@v1.8.20...v1.8.22)

Updates `org.jetbrains.kotlin:kotlin-stdlib-jdk8` from 1.8.20 to 1.8.22
- [Release notes](https:/JetBrains/kotlin/releases)
- [Changelog](https:/JetBrains/kotlin/blob/v1.8.22/ChangeLog.md)
- [Commits](JetBrains/kotlin@v1.8.20...v1.8.22)

---
updated-dependencies:
- dependency-name: org.jetbrains.kotlin:kotlin-gradle-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.jetbrains.kotlin:kotlin-stdlib-jdk8
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps androidx.core:core-ktx from 1.10.0 to 1.10.1.

---
updated-dependencies:
- dependency-name: androidx.core:core-ktx
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
- Precondition: isAutomaticReconnect is true

- MqttConnection make MqttAsyncClient instance -> Network state changed(Connected) -> MqttConnection reconnect(synchronized fun) -> MqttConnection setConnectingState wait(synchronized fun) -> MqttAsyncClient reconnect -> MqttAsyncClient stopReconnectCycle fun -> connOpts is null

org.eclipse.paho.client.mqttv3.MqttAsyncClient.stopReconnectCycle (MqttAsyncClient.java:1451)
org.eclipse.paho.client.mqttv3.MqttAsyncClient.reconnect (MqttAsyncClient.java:1404)
info.mqtt.android.service.MqttConnection$reconnect$1.invokeSuspend (MqttConnection.kt:746)
kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith (ContinuationImpl.kt:30)
(cherry picked from commit 8266d64)
@SM2A
Copy link

SM2A commented Jan 17, 2024

Without a doubt you are much more experienced than me
The reason that the tests are failing is exactly what I am facing
Maybe it's needed to dived registerReceiver method into pre api 34 and post 34 that have RECEIVER_NOT_EXPORTED flag

@hannesa2
Copy link
Owner Author

Now it miss something described here https://developer.android.com/about/versions/14/changes/schedule-exact-alarms

@SM2A
Copy link

SM2A commented Jan 17, 2024

Specifying these two permission in manifest will fix it

<uses-permission android:name="android.permission.SCHEDULE_EXACT_ALARM" />
<uses-permission android:name="android.permission.USE_EXACT_ALARM" />

@hannesa2
Copy link
Owner Author

There is already one of them. https:/hannesa2/paho.mqtt.android/blob/api34-3.x/serviceLibrary/src/main/AndroidManifest.xml

Please make a pull request based on my branch, then we see, if all is fine then

@hannesa2 hannesa2 force-pushed the api34-3.x branch 2 times, most recently from 16644a5 to a7392a7 Compare January 17, 2024 18:32
@hannesa2 hannesa2 merged commit a80aaef into v3.5.3 Jan 17, 2024
6 checks passed
@hannesa2 hannesa2 deleted the api34-3.x branch January 17, 2024 19:00
@hannesa2 hannesa2 changed the title Api34 3.x api34 for version 3.x Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants