Grant SCHEDULE_EXACT_ALARM permission in instrumentation test #551
Conversation
|
When you push now, it should build as well. |
|
Yes yes I will make new clean branch |
Sorry, this is not the benchmark. The CI should work. |
I wasn't trying to say that it works on my device, I wanted you to know I am trying to make it working on CI |
|
I think errors about using ALARM are fixed but now time out causing tests to fail. Is the server up and running? |
yes #552 |
|
After a few hours of searching I found what the problem was. |
| context.registerReceiver(receiver, filter, Context.RECEIVER_NOT_EXPORTED) | ||
| } else | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) | ||
| context.registerReceiver(receiver, filter, Context.RECEIVER_EXPORTED) |
There was a problem hiding this comment.
Not really sure about what I'm going to say but I think because the instrumentation test app and the library are on different places. It took me while to find out that the broadcasts send by the callbackToActivity function are not received by the MqttAndroidClient broadcast receiver. It fixed by this change.
It might work in real app
There was a problem hiding this comment.
| @@ -6,6 +6,8 @@ | |||
| <!-- Permissions the Application Requires --> | |||
| <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" /> | |||
| <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" /> | |||
| <uses-permission android:name="android.permission.SCHEDULE_EXACT_ALARM" /> | |||
There was a problem hiding this comment.
I guess I merged too fast.
This should be only in library
| @@ -6,6 +6,8 @@ | |||
| <uses-permission android:name="android.permission.POST_NOTIFICATIONS" /> | |||
| <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" /> | |||
| <uses-permission android:name="android.permission.FOREGROUND_SERVICE" /> | |||
| <uses-permission android:name="android.permission.SCHEDULE_EXACT_ALARM" /> | |||
| @@ -1,5 +1,8 @@ | |||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android"> | |||
|
|
|||
| <uses-permission android:name="android.permission.SCHEDULE_EXACT_ALARM" /> | |||
I wasn't able to run android test on CI
Please approve this pull request CI checks so I can make sure every thing is fine