Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove foreground notification when the service is started in foreground #560

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Remove foreground notification when the service is started in foreground #560

merged 2 commits into from
Feb 15, 2024

Conversation

fabmazz
Copy link
Contributor

@fabmazz fabmazz commented Feb 15, 2024

Replace calling stopSelf with a new method that also removes the foreground service stuff

@hannesa2
Copy link
Owner

hannesa2 commented Feb 15, 2024 •
edited
Loading

Thanks a lot for your contribution. I guess you can solve check detection by simply format touched files.
Btw, the formatter rules are already checked in

@hannesa2 hannesa2 merged commit f7560d7 into hannesa2:master Feb 15, 2024
2 checks passed
@hannesa2
Copy link
Owner

Thank you. Perfect would be a test for this

@NinaTietje NinaTietje mentioned this pull request Apr 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabmazz @hannesa2