Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOT A PR: Bug with Node 22 on all OSs #332

Closed
wants to merge 4 commits into from

Conversation

damusix
Copy link
Contributor

@damusix damusix commented Jun 26, 2024

Issue with Node 22 where cookies are not being sent by websockets. Console logging headers to trace what is being sent in all versions via pipeline, and isolation to only the test suite that is causing the issues.

Marsup and others added 3 commits November 8, 2023 12:41
Unskip tests that were previously skipped and aren't failing. Fix JSON parse failure expectation given error message change after Node version 20.
Copy link
Contributor Author

@damusix damusix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below are the places to look at to see the messages sent / received by WS server / client

@@ -467,10 +467,14 @@
return Promise.reject(err);
}

console.log('send...', encoded);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message being sent

@@ -657,6 +661,8 @@
return this.onError(new NesError(err, errorTypes.PROTOCOL));
}

console.log('update...', update);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message received from server

@@ -49,6 +50,8 @@ exports = module.exports = internals.Listener = function (server, settings) {
return ws.close();
}

console.log('ws on connection....', req.headers);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Headers sent on connection

Headers are not being passed by websocket in node 22 only and causing
cookie authentication to fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants