Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev dependencies to use uptodate packages #2859

Merged
merged 1 commit into from
Aug 22, 2017

Conversation

stof
Copy link
Collaborator

@stof stof commented Jul 31, 2017

All dependencies used in the build system were totally outdated (and may not work well on recent versions of node). This updates them.

@@ -7,7 +7,7 @@
<link rel="stylesheet" href="docsupport/prism.css">
<link rel="stylesheet" href="chosen.css">

<meta http-equiv="Content-Security-Policy" content="default-src 'self'; script-src 'self' https://ajax.googleapis.com; style-src 'self'; img-src 'self' data:">
<meta http-equiv="Content-Security-Policy" content="default-src &apos;self&apos;; script-src &apos;self&apos; https://ajax.googleapis.com; style-src &apos;self&apos;; img-src &apos;self&apos; data:">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this right? Looking around, it seems like most "Content-Security-Policy" examples use the single-quote-inside-double-quote thing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, escaping is not required, but it is allowed (this is something happening at the HTML level, so the final value has single quotes after parsing).

Escaping the single quote is the result of running dom_munger as part of the prep-release task (the fact that it was not escaped yet is because this change was reverted manually when doing the 1.7.0 release)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird, but it seems to work, so okay ¯\_(ツ)_/¯

@tjschuck tjschuck merged commit 18a4c0b into harvesthq:master Aug 22, 2017
@stof stof deleted the update_deps branch November 9, 2017 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants