Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor validation logic in the server package #2790

Closed
victor-yanev opened this issue Aug 5, 2024 · 0 comments · Fixed by #2791
Closed

Refactor validation logic in the server package #2790

victor-yanev opened this issue Aug 5, 2024 · 0 comments · Fixed by #2791
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@victor-yanev
Copy link
Contributor

Problem

Currently the logic in the server validator is really tangled up and hard to maintain, also there are several bugs inside which need to be addressed.

Solution

  • Add typing to schema definitions
  • Simplify the logic in the utils.ts file
  • Give better control of the person describing how the validator should work inside the object schema

Alternatives

No response

@victor-yanev victor-yanev added the enhancement New feature or request label Aug 5, 2024
@victor-yanev victor-yanev added this to the 0.54.0 milestone Aug 5, 2024
@victor-yanev victor-yanev self-assigned this Aug 5, 2024
@victor-yanev victor-yanev changed the title Refactor code in packages/server/src/validator Refactor code for server method validations Aug 5, 2024
@victor-yanev victor-yanev changed the title Refactor code for server method validations Refactor validation logic in the server package Aug 5, 2024
@quiet-node quiet-node modified the milestones: 0.54.0, 0.55.0 Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants