Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary empty Trie initialization #2839

Closed
natanasow opened this issue Aug 19, 2024 · 0 comments · Fixed by #2840
Closed

Remove unnecessary empty Trie initialization #2839

natanasow opened this issue Aug 19, 2024 · 0 comments · Fixed by #2840
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@natanasow
Copy link
Collaborator

Problem

The empty trie root hash can be defined as constant because it can't be changed so there is no actual gain in performance or code readability. The initialization of an empty trie here can be deprecated and replaced with a constant variable.

Solution

Remove the initialization here and define a new constant that wraps an empty trie root hash.

Alternatives

No response

@natanasow natanasow added the enhancement New feature or request label Aug 19, 2024
@natanasow natanasow self-assigned this Aug 19, 2024
@natanasow natanasow added this to the 0.55.0 milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant