Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth_getLogs transactionHash + blockHash not hash32 #289

Closed
rafaelkallis opened this issue Jul 1, 2022 · 0 comments · Fixed by #294
Closed

eth_getLogs transactionHash + blockHash not hash32 #289

rafaelkallis opened this issue Jul 1, 2022 · 0 comments · Fixed by #294
Assignees
Labels
bug Something isn't working P1
Milestone

Comments

@rafaelkallis
Copy link
Contributor

Description

related to #268

When performing eth_getLogs the response is not valid. According to https:/ethereum/execution-apis/blob/main/src/schemas/receipt.yaml#L16-L21 the transactionHash and blockHash properties are hash32 (^0x[0-9a-f]{64}$), the relay response however uses the full 48 byte representation (^0x[0-9a-f]{96}$).

A json-rpc client with client-side validation, such as go-ethereum, throws validation exceptions in such cases.

Steps to reproduce

curl -X POST $BASE_URL \
                                       -H 'Content-Type: application/json' \
                                       -d "{\"id\":\"2\",\"jsonrpc\":\"2.0\",\"method\":\"eth_getLogs\",\"params\":[{\"blockhash\":\"$BLOCK_HASH\", \"address\":\"$ADDRESS\"}]}" --silent

where BASE_URL is either a local relay node (testnet) or https://testnet.hashio.io/api
where BLOCK_HASH is 0xc28a3f6447377809b1ecf7cf5ea252bfd3d0da593ef4d75539907f0e46b2019372aa4b43c25ded5d0d00ac322fcae3dc
where ADDRESS is 0x0000000000000000000000000000000002bcc93e

Additional context

Current relay response log:
image

Hedera network

testnet

Version

0.2.0

Operating system

Linux

@rafaelkallis rafaelkallis added the bug Something isn't working label Jul 1, 2022
@Nana-EC Nana-EC added the P1 label Jul 1, 2022
@Nana-EC Nana-EC added this to the 0.3.0 milestone Jul 1, 2022
@Nana-EC Nana-EC self-assigned this Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants