Websocket subscription creates the same subscription ID for new connection from the same client

[simsonraj]

Description

when making new subscription requests from the same client, Hedera creates the same Subscription ID, whereas it should be creating a new one every time similar to other chains. this is critical because our nodes are not able to handle multiple RPC connections in a single node, causing tons of errors

Steps to reproduce

make multiple new subscription requests to

    "jsonrpc": "2.0",
    "id": 1,
    "method": "eth_subscribe",
  "params": ["newHeads"]
}

when tried to connect with multiple connections for parallelisation, the existing context gets hung due to the same subscription ID
a new subscription request

Additional context

Hedera network

testnet

Version

latest

Operating system

None

[Neurone]

This is intended behavior:

hedera-json-rpc-relay/packages/relay/tests/lib/subscriptionController.spec.ts

Line 252 in 5018b23

it('Subscribing to the same event and filters should return the same subscription id', async function () {

As a temporary solution to make the relay work as you expect, comment this test and the implementation:

hedera-json-rpc-relay/packages/relay/src/lib/subscriptionController.ts

Lines 102 to 107 in 5018b23

	// Check if the connection is already subscribed to this event
	const existingSub = this.subscriptions[tag].find((sub) => sub.connection.id === connection.id);
	if (existingSub) {
	this.logger.debug(`Connection ${connection.id}: Attempting to subscribe to ${tag}; already subscribed`);
	return existingSub.subscriptionId;
	}

Waiting for the engineering team to make a decision here, my suggestion is to introduce an env variable to let choose this behavior.