Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feeHistory exchangeRate logic to use MirrorNode #85

Closed
Nana-EC opened this issue May 23, 2022 · 0 comments · Fixed by #278
Closed

Update feeHistory exchangeRate logic to use MirrorNode #85

Nana-EC opened this issue May 23, 2022 · 0 comments · Fixed by #278
Assignees
Labels
enhancement New feature or request P1
Milestone

Comments

@Nana-EC
Copy link
Collaborator

Nana-EC commented May 23, 2022

Problem

Currently the feeHistory call uses the mocked mirrorNode.getFeeHistory()
This includes mocked logic that shouldn't be relied on to get the most recent block

Solution

Update this to use a valid implementation
Given our fees don't change often result should be as follows

{
  baseFeePerGas: Array of all the fees.servicedata.gas for each record in weibars
  gasUsedRatio: Array of n - m  values of 0.5 i.e. [0.5, 0.5, 0.5 ...]
  oldestBlock: n
}

Current the mirrorNode file has similar logic. Adopt this and move into eth.ts

Alternatives

No response

@Nana-EC Nana-EC added enhancement New feature or request P2 labels May 23, 2022
@Nana-EC Nana-EC added this to the 0.2.0 milestone May 31, 2022
@Nana-EC Nana-EC removed this from the 0.2.0 milestone May 31, 2022
@Nana-EC Nana-EC added this to the 0.3.0 milestone Jun 20, 2022
@Nana-EC Nana-EC added P1 and removed P2 labels Jun 21, 2022
@ar-conmit ar-conmit self-assigned this Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants