eth_getLogs #103
Merged
eth_getLogs #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
# Conflicts: # packages/relay/src/index.ts # packages/relay/src/lib/eth.ts # packages/relay/tests/lib/eth.spec.ts
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
# Conflicts: # packages/relay/src/index.ts # packages/relay/src/lib/model.ts # packages/server/tests/server.spec.ts
Signed-off-by: Ivo Yankov <[email protected]>
Closed
Codecov Report
@@ Coverage Diff @@
## main #103 +/- ##
==========================================
+ Coverage 60.84% 66.53% +5.68%
==========================================
Files 4 4
Lines 424 490 +66
Branches 56 66 +10
==========================================
+ Hits 258 326 +68
+ Misses 151 147 -4
- Partials 15 17 +2
Continue to review full report at Codecov.
|
Nana-EC
requested changes
May 28, 2022
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Nana-EC
previously approved these changes
Jun 1, 2022
packages/relay/tests/lib/eth.spec.ts
Outdated
|
|
||
| describe('eth_getLogs', async function () { | ||
|
|
||
| const expectLogData1 = (res) => { |
There was a problem hiding this comment.
nit: A few shared checks in here can be pulled out.
const expectLogData = (res) => {
expect(res.blockHash).to.eq(defaultDetailedContractResults.block_hash);
expect(res.blockNumber).to.eq(defaultDetailedContractResults.block_number);
expect(res.removed).to.eq(false);
expect(res.topics).to.exist;
expect(res.transactionHash).to.eq(defaultDetailedContractResults.hash);
expect(res.transactionIndex).to.eq(defaultDetailedContractResults.transaction_index);
};Then each expectLogDataX(res) can call expectLogData(res)
Signed-off-by: Ivo Yankov <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Daniel-K-Ivanov
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue(s):
Fixes #
#20
Notes for reviewer:
Checklist