-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding polling for new heads. #2160
Conversation
Signed-off-by: ebadiere <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2160 +/- ##
=======================================
Coverage 75.15% 75.15%
=======================================
Files 13 13
Lines 644 644
Branches 118 118
=======================================
Hits 484 484
Misses 115 115
Partials 45 45 ☔ View full report in Codecov by Sentry. |
Signed-off-by: ebadiere <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few items.
Also please update the PR with a description
package.json
Outdated
@@ -72,7 +73,7 @@ | |||
"keyv-file": "^0.3.0", | |||
"koa-cors": "^0.0.16", | |||
"koa-websocket": "^7.0.0", | |||
"lerna": "^8.1.1", | |||
"lerna": "^8.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: why are we bumping down?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a new entry to the scripts in the package.json, and I suspect I didn't have the latest which was updated by a snyk. The version is updated.
@@ -20,3 +20,4 @@ DEBUG_API_ENABLED=true | |||
SEND_RAW_TRANSACTION_SIZE_LIMIT=131072 | |||
BATCH_REQUESTS_ENABLED=true | |||
TEST_GAS_PRICE_DEVIATION=0.2 | |||
WS_NEW_HEADS_ENABLED=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default to false for this sprint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
…tance to false. Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Added polling for latest block,
newHeads
. This feature allows the relay to be polled for the latest blocks. This can be used by automated systems and oracles.Related issue(s): #2117
Fixes #