feat: Updated design document to include JSON RPC support. #2183
Conversation
Signed-off-by: ebadiere <[email protected]>
ebadiere
added
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2183 +/- ##
=======================================
Coverage 75.15% 75.15%
=======================================
Files 13 13
Lines 644 644
Branches 118 118
=======================================
Hits 484 484
Misses 115 115
Partials 45 45 ☔ View full report in Codecov by Sentry. |
Signed-off-by: ebadiere <[email protected]>
| "logsBloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", | ||
| "miner": "0xf8b483dba2c3b7176a3da549ad41a48bb3121069", | ||
| "nonce": "0x084149998194cc5f", | ||
| "number": "0x1348c9", | ||
| "parentHash": "0x7736fab79e05dc611604d22470dadad26f56fe494421b5b333de816ce1f25701", | ||
| "receiptRoot": "0x2fab35823ad00c7bb388595cb46652fe7886e00660a01e867824d3dceb1c8d36", | ||
| "receiptsRoot": "0x2fab35823ad00c7bb388595cb46652fe7886e00660a01e867824d3dceb1c8d36", |
There was a problem hiding this comment.
Both Geth and Infura docs use singular receiptRoot
- https://geth.ethereum.org/docs/interacting-with-geth/rpc/pubsub
- https://docs.infura.io/api/networks/ethereum/json-rpc-methods/subscription-methods/eth_subscribe
However, Alchemy uses plural https://docs.alchemy.com/reference/newheads
There was a problem hiding this comment.
Our blocks contain receiptsRoot, plural.
Signed-off-by: ebadiere <[email protected]>
ebadiere
requested review from
AlfredoG87,
georgi-l95,
Ivo-Yankov and
Nana-EC
as code owners
described the need for JSON-RPC over websockets support in other words. Signed-off-by: ebadiere <[email protected]>
|
|
Replaced by #2230 |
Design document update. Add JSON RPC calls to the relay from the
webSocketServer.tsRelated issue(s): #2117
Fixes #
Notes for reviewer:
Checklist