fix: HotFix for using mSet instead of Set for redis cache when storing synthetic transactions #2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edis cache Signed-off-by: Alfredo Gutierrez <[email protected]>
AlfredoG87
changed the title
Nana-EC
requested changes
Mar 14, 2024
Signed-off-by: Alfredo Gutierrez <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/0.43 #2197 +/- ##
=============================================
Coverage 75.15% 75.15%
=============================================
Files 13 13
Lines 644 644
Branches 118 118
=============================================
Hits 484 484
Misses 115 115
Partials 45 45 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Alfredo Gutierrez <[email protected]>
Nana-EC
reviewed
Mar 14, 2024
…to the end so we dont capture and then fail (if it fails) Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
|
@Nana-EC I've added unit tests that verify that |
|
AlfredoG87
added
bug
AlfredoG87
requested review from
ebadiere,
lukelee-sl and
a team
as code owners
ebadiere
approved these changes
Mar 14, 2024
Nana-EC
approved these changes
Mar 14, 2024
AlfredoG87
added a commit
that referenced
this pull request
Mar 18, 2024
…g synthetic transactions (#2197) * Fix to use mSet instead of set, so we can batch the requests to the redis cache Signed-off-by: Alfredo Gutierrez <[email protected]> * Feedback of PR Review Signed-off-by: Alfredo Gutierrez <[email protected]> * some improvements Signed-off-by: Alfredo Gutierrez <[email protected]> * add missing metric observations and leaving the metrics observations to the end so we dont capture and then fail (if it fails) Signed-off-by: Alfredo Gutierrez <[email protected]> * adding unit tests for MultiSet state changes on the cache Signed-off-by: Alfredo Gutierrez <[email protected]> --------- Signed-off-by: Alfredo Gutierrez <[email protected]>
2 tasks
AlfredoG87
added a commit
that referenced
this pull request
Mar 18, 2024
fix: HotFix for using mSet instead of Set for redis cache when storing synthetic transactions (#2197) * Fix to use mSet instead of set, so we can batch the requests to the redis cache * Feedback of PR Review * some improvements * add missing metric observations and leaving the metrics observations to the end so we dont capture and then fail (if it fails) * adding unit tests for MultiSet state changes on the cache --------- Signed-off-by: Alfredo Gutierrez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
mSetfor ICacheClientfilterAndPopulateSyntheticContractResultsto use mSet instead of set.Related issue(s):
Fixes #
Notes for reviewer:
Checklist