fix: added support for legacy pre EIP 155 transactions with no chainID (chainId=0x0) #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Logan Nguyen <[email protected]>
…D=0x0 Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
quiet-node
requested review from
AlfredoG87,
ebadiere,
Nana-EC,
a team and
lukelee-sl
as code owners
Nana-EC
reviewed
Mar 21, 2024
lukelee-sl
reviewed
Mar 21, 2024
packages/relay/src/lib/precheck.ts
Outdated
| @@ -100,7 +100,7 @@ export class Precheck { | |||
| chainId(tx: Transaction, requestId?: string) { | |||
| const requestIdPrefix = formatRequestIdMessage(requestId); | |||
| const txChainId = prepend0x(Number(tx.chainId).toString(16)); | |||
| const passes = txChainId === this.chain; | |||
| const passes = txChainId === '0x0' || txChainId === this.chain; | |||
There was a problem hiding this comment.
should we tighten this up a bit by checking to see if the v value is 27 or 28 (for legacy transactions) when the chain_id is zero?
There was a problem hiding this comment.
Yes this makes sense! Just pushed in an update for it
Signed-off-by: Logan Nguyen <[email protected]>
quiet-node
force-pushed
the
2201-support-eip-155-default-v
branch
from
776c312
to
c589e4b
Compare
|
AlfredoG87
pushed a commit
that referenced
this pull request
Mar 22, 2024
…D (chainId=0x0) (#2228) * feat: added support for legacy unprotected ETX pre EIP-155 (chainID=0x0) Signed-off-by: Logan Nguyen <[email protected]> * test: added new UT for precheck.chainId() with a case that has chainID=0x0 Signed-off-by: Logan Nguyen <[email protected]> * test: fixed UT to allow support for pre EIP155 txs Signed-off-by: Logan Nguyen <[email protected]> * feat: added isLegacyUnprotectedEtx() method Signed-off-by: Logan Nguyen <[email protected]> --------- Signed-off-by: Logan Nguyen <[email protected]>
2 tasks
AlfredoG87
added a commit
that referenced
this pull request
Mar 22, 2024
#2240) fix: added support for legacy pre EIP 155 transactions with no chainID (chainId=0x0) (#2228) * feat: added support for legacy unprotected ETX pre EIP-155 (chainID=0x0) * test: added new UT for precheck.chainId() with a case that has chainID=0x0 * test: fixed UT to allow support for pre EIP155 txs * feat: added isLegacyUnprotectedEtx() method --------- Signed-off-by: Logan Nguyen <[email protected]> Co-authored-by: Logan Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces a check method,
isLegacyUnprotectedEtx(), within theprecheckclass and utilized it inprecheck.chainId(), allows for compatibility with pre EIP 155 transactions (chainId=0x0, defaultv = {27, 28}). Additionally, the PR added new UT coverage for the update and resolves any related UT issues.Related issue(s):
Fixes #2201
Notes for reviewer:
Checklist