Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update actions/download-artifact and actions/upload-artifact to v4 #2615

Conversation

yaroslav-007
Copy link
Contributor

Description:
This PR is addressing the following note:

Warning

actions/upload-artifact@v3 is scheduled for deprecation on November 30, 2024. [Learn more.](https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/) Similarly, v1/v2 are scheduled for deprecation on June 30, 2024. Please update your workflow to use v4 of the artifact actions. This deprecation will not impact any existing versions of GitHub Enterprise Server being used by customers.

It has addressed the Breaking Changes in v4 where is needed:

Uploading to the same named Artifact multiple times.

Due to how Artifacts are created in this new version, it is no longer possible to upload to the same named Artifact multiple times. You must either split the uploads into multiple Artifacts with different names, or only upload once. Otherwise you will encounter an error.

Related issue(s):

Fixes #2596

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@yaroslav-007 yaroslav-007 self-assigned this Jun 21, 2024
Copy link

sonarcloud bot commented Jun 21, 2024

@yaroslav-007 yaroslav-007 requested a review from isavov June 21, 2024 10:08
Copy link

github-actions bot commented Jun 21, 2024

Tests

       3 files     216 suites   17s ⏱️
1 134 tests 1 133 ✔️ 1 💤 0
1 146 runs  1 145 ✔️ 1 💤 0

Results for commit 66e2a07.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 21, 2024

Acceptance Tests

  16 files  213 suites   27m 34s ⏱️
596 tests 592 ✔️ 4 💤 0
612 runs  608 ✔️ 4 💤 0

Results for commit 66e2a07.

♻️ This comment has been updated with latest results.

@isavov isavov marked this pull request as ready for review August 27, 2024 09:16
Copy link
Collaborator

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.

@ebadiere
Copy link
Collaborator

@yaroslav-007 I am unable to re-run the failing jobs. I don't think the failures are due to your update.

@isavov isavov added enhancement New feature or request github_actions labels Aug 28, 2024
@isavov isavov added this to the 0.55.0 milestone Aug 28, 2024
@isavov isavov force-pushed the 2596-update-upload-artifactdownload-artifact-versions-for-test-reports branch from 57a64d0 to 66e2a07 Compare August 28, 2024 12:12
Copy link

sonarcloud bot commented Aug 28, 2024

@isavov isavov merged commit 4932399 into main Aug 28, 2024
45 checks passed
@isavov isavov deleted the 2596-update-upload-artifactdownload-artifact-versions-for-test-reports branch August 28, 2024 13:14
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.94%. Comparing base (02fc679) to head (66e2a07).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2615      +/-   ##
==========================================
+ Coverage   82.88%   82.94%   +0.05%     
==========================================
  Files          47       47              
  Lines        3483     3483              
  Branches      739      739              
==========================================
+ Hits         2887     2889       +2     
+ Misses        366      364       -2     
  Partials      230      230              
Flag Coverage Δ
relay 82.66% <ø> (+0.07%) ⬆️
server 83.05% <ø> (ø)
ws-server 97.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update upload-artifact/download-artifact versions for test reports
3 participants