Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated the account from the 0.0.2 account to an account from th… #2690

Merged
merged 11 commits into from
Jul 23, 2024

Conversation

ebadiere
Copy link
Collaborator

@ebadiere ebadiere commented Jul 9, 2024

Use an account other than 0.0.2 for running tests. Removed "Out of Memory" error check in CI.. PR #2695 covers memory leaks.
Related issue(s): #2671

…e local node to track

transaction costs.

Signed-off-by: ebadiere <[email protected]>
@ebadiere ebadiere requested review from AlfredoG87, Nana-EC and a team as code owners July 9, 2024 15:15
@ebadiere ebadiere self-assigned this Jul 9, 2024
@ebadiere ebadiere added the bug Something isn't working label Jul 9, 2024
@ebadiere ebadiere added this to the 0.52.0 milestone Jul 9, 2024
Copy link

github-actions bot commented Jul 9, 2024

Acceptance Tests

     22 files     279 suites   42m 11s ⏱️
   609 tests    602 ✔️ 4 💤 3
1 054 runs  1 042 ✔️ 6 💤 6

Results for commit c698254.

♻️ This comment has been updated with latest results.

Nana-EC
Nana-EC previously approved these changes Jul 9, 2024
Copy link

github-actions bot commented Jul 9, 2024

Tests

    2 files  161 suites   12s ⏱️
867 tests 866 ✔️ 1 💤 0
880 runs  879 ✔️ 1 💤 0

Results for commit c698254.

♻️ This comment has been updated with latest results.

@quiet-node
Copy link
Member

The PR title seems to got cut off. Please update it before merging.

Signed-off-by: ebadiere <[email protected]>

fix: Updated the private key to the hex ECDSA value.

Signed-off-by: ebadiere <[email protected]>

fix: Bumped up the gasLimit to the required amount to activate a hollow account.

Signed-off-by: ebadiere <[email protected]>
Ivo-Yankov
Ivo-Yankov previously approved these changes Jul 17, 2024
Copy link
Collaborator

@Ivo-Yankov Ivo-Yankov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebadiere ebadiere marked this pull request as ready for review July 18, 2024 21:06
quiet-node
quiet-node previously approved these changes Jul 19, 2024
Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link

sonarcloud bot commented Jul 22, 2024

Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@georgi-l95 georgi-l95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG 👍

@ebadiere ebadiere merged commit a75f5b5 into main Jul 23, 2024
35 checks passed
@ebadiere ebadiere deleted the 2671-update-OPERATOR_ID branch July 23, 2024 12:15
ebadiere added a commit that referenced this pull request Aug 1, 2024
#2690)

* fix: Updated the account from the 0.0.2 account to an account from the local node to track
transaction costs.

Signed-off-by: ebadiere <[email protected]>

* fix: Turning off test to potentially get through CI.
Opened issue: #2700

Signed-off-by: ebadiere <[email protected]>

* fix: WIP: Pushing up to collaborate

Signed-off-by: ebadiere <[email protected]>

fix: Updated the private key to the hex ECDSA value.

Signed-off-by: ebadiere <[email protected]>

fix: Bumped up the gasLimit to the required amount to activate a hollow account.

Signed-off-by: ebadiere <[email protected]>

* fix:  Added key format support to the serviceClient.

Signed-off-by: ebadiere <[email protected]>

* fix: Extracted the createPrivateKeyBasedOnFormat(key) to the Utils class.

Signed-off-by: ebadiere <[email protected]>

* fix: Updated import of createPrivateKeyBasedOnFormat from Utils.

Signed-off-by: ebadiere <[email protected]>

* fix: Removed memory leak check.  PR 26954 addresses memory leaks.

Signed-off-by: ebadiere <[email protected]>

* fix:  Removed null test because an env var which is a string cannot be
set to null

Signed-off-by: ebadiere <[email protected]>

* fix: Removed the comment in the GH workflow

Signed-off-by: ebadiere <[email protected]>

---------

Signed-off-by: ebadiere <[email protected]>
Signed-off-by: Eric Badiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants