Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: deprecate ETH_POPULATE_SYNTHETIC_CONTRACT_RESULTS env… #2783

Closed
wants to merge 1 commit into from

Conversation

ebadiere
Copy link
Collaborator

@ebadiere ebadiere commented Aug 2, 2024

Reverts "feat: deprecate ETH_POPULATE_SYNTHETIC_CONTRACT_RESULTS env (#2768)"

This reverts commit e0fc473.

Description:

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ebadiere ebadiere added the bug Something isn't working label Aug 2, 2024
@ebadiere ebadiere added this to the 0.53.0 milestone Aug 2, 2024
@ebadiere ebadiere self-assigned this Aug 2, 2024
Copy link

sonarcloud bot commented Aug 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
11.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

github-actions bot commented Aug 2, 2024

Tests

    2 files  162 suites   13s ⏱️
881 tests 880 ✔️ 1 💤 0
894 runs  893 ✔️ 1 💤 0

Results for commit 9635561.

Copy link

github-actions bot commented Aug 2, 2024

Acceptance Tests

     25 files  315 suites   37m 32s ⏱️
   613 tests 569 ✔️ 4 💤 40
1 015 runs  963 ✔️ 6 💤 46

Results for commit 9635561.

Copy link
Collaborator

@natanasow natanasow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regression has been fixed in #2784 but approve this one too.

@ebadiere
Copy link
Collaborator Author

ebadiere commented Aug 2, 2024

Not needed. PR #2784

@ebadiere ebadiere closed this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants