fix: captured and added FileInfo query costs to metrics and hbar ratelimit class #2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… limit class Signed-off-by: Logan Nguyen <[email protected]> Revert "fix: captured and added FileInfo query costs to metrics and hbar rate limit class" This reverts commit 3fe8bd80de5763b9d2803a0bb0e426f7c8ed2228. Reapply "fix: captured and added FileInfo query costs to metrics and hbar rate limit class" This reverts commit 8037a7a3baae152d18339e1589ddca37e12bd665. s Signed-off-by: Logan Nguyen <[email protected]>
quiet-node
requested review from
AlfredoG87,
ebadiere,
lukelee-sl and
a team
as code owners
|
ebadiere
reviewed
Aug 14, 2024
ebadiere
reviewed
Aug 14, 2024
The additional code was added to pretty much modify the code layout, but the overall flow remains unchanged. There are already acceptance and unit tests for that. I believe the warning is sort of based on only to the newly added code. |
ebadiere
approved these changes
Aug 14, 2024
quiet-node
deleted the
2738-capture-and-add-fileinfo-query-costs-to-metrics-and-hbar-rate-limiter-class-II
branch
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2822 +/- ##
==========================================
+ Coverage 81.12% 81.29% +0.17%
==========================================
Files 46 46
Lines 3386 3385 -1
Branches 707 706 -1
==========================================
+ Hits 2747 2752 +5
+ Misses 418 408 -10
- Partials 221 225 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ebadiere
pushed a commit
that referenced
this pull request
Aug 21, 2024
…limit class (#2822) fix: captured and added FileInfo query costs to metrics and hbar rate limit class Revert "fix: captured and added FileInfo query costs to metrics and hbar rate limit class" This reverts commit 3fe8bd80de5763b9d2803a0bb0e426f7c8ed2228. Reapply "fix: captured and added FileInfo query costs to metrics and hbar rate limit class" This reverts commit 8037a7a3baae152d18339e1589ddca37e12bd665. s Signed-off-by: Logan Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
captured and added FileInfo query costs to metrics and hbar ratelimit class
Related issue(s):
Fixes #2738
Notes for reviewer:
Checklist