fix: eth_estimateGas opts to fallback estimation for contract revert

[victor-yanev]

Description:

This PR modifies the EthImpl class to improve error handling for gas estimation.

• Add logic to return predefined.CONTRACT_REVERT JSON-RPC error with the revert reason in case of contract revert
• Extend predefined.CONTRACT_REVERT to cover more edge cases when decoding error messages
• Extend tests for decodeErrorMessage and predefined.CONTRACT_REVERT
• Extend tests for eth_estimateGas with the new logic for reverting calls

Related issue(s):

Fixes #2830

Solves problem in #2821

Notes for reviewer:

Checklist

• Documented (Code comments, README, etc.)
• Tested (unit, integration, etc.)

[github-actions]

Acceptance Tests

  18 files  225 suites   28m 23s ⏱️
611 tests 591 ✔️ 4 💤 16 ❌
719 runs  699 ✔️ 4 💤 16 ❌

Results for commit a2d38ea.

♻️ This comment has been updated with latest results.

[acuarica]

Shouldn't we include some tests for this new scenario?

[victor-yanev]

Shouldn't we include some tests for this new scenario?

Good point, I will extend the tests for eth_estimateGas

[github-actions]

Tests

       3 files     203 suites   53s ⏱️
1 030 tests 1 029 ✔️ 1 💤 0 ❌
1 043 runs  1 042 ✔️ 1 💤 0 ❌

Results for commit a2d38ea.

♻️ This comment has been updated with latest results.

[acuarica]

looking good, left some questions

[acuarica]

Nit: I think we should the remove the "Fixes #2821" from this PR's description, and replace it by something like "Related to #2821". The reason is that we wouldn't want to close #2821 when we merge this PR, but instead close it when the Axelar team can effectively confirm the issue is solved, which is when we make a new release containing this fix.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[natanasow]

LGTM

[codecov]

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.28%. Comparing base (59a808d) to head (a2d38ea).
Report is 5 commits behind head on main.

Files	Patch %	Lines
packages/relay/src/lib/eth.ts	33.33%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2834      +/-   ##
==========================================
+ Coverage   81.26%   81.28%   +0.02%     
==========================================
  Files          46       46              
  Lines        3394     3415      +21     
  Branches      707      716       +9     
==========================================
+ Hits         2758     2776      +18     
+ Misses        414      410       -4     
- Partials      222      229       +7     

Flag	Coverage Δ
relay	80.94% <81.81%> (+0.03%)	⬆️
server	81.53% <ø> (ø)
ws-server	97.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
packages/relay/src/lib/errors/JsonRpcError.ts	70.58% <100.00%> (+4.63%)	⬆️
...ages/relay/src/lib/errors/MirrorNodeClientError.ts	87.50% <100.00%> (+1.13%)	⬆️
packages/relay/src/lib/eth.ts	81.04% <33.33%> (-0.53%)	⬇️

... and 2 files with indirect coverage changes