-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Bug due to validations of eth_call
#2843
Conversation
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
…-package Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
…-package Signed-off-by: Victor Yanev <[email protected]>
…-package Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
🚨 Memory Leak Detected 🚨A potential memory leak has been detected in the test titled Details📊 Memory Leak Detection Report 📊 GC Type: Scavenge Heap Statistics (before vs after executing the test):
Heap Space Statistics (before vs after executing the test):
RecommendationsPlease investigate the memory allocations in this test, focusing on objects that are not being properly deallocated. |
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]> # Conflicts: # packages/server/src/types/validator/objectTypes.ts # packages/server/src/validator/objectTypes.ts
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2843 +/- ##
==========================================
+ Coverage 79.76% 81.19% +1.42%
==========================================
Files 30 46 +16
Lines 2718 3403 +685
Branches 586 717 +131
==========================================
+ Hits 2168 2763 +595
- Misses 356 409 +53
- Partials 194 231 +37
Flags with carried forward coverage won't be shown. Click here to find out more.
|
* refactor: Validation logic in the `server` package Signed-off-by: Victor Yanev <[email protected]> * fix: rpc_batch3.spec.ts Signed-off-by: Victor Yanev <[email protected]> * fix: rpc_batch3.spec.ts Signed-off-by: Victor Yanev <[email protected]> * chore: address comments Signed-off-by: Victor Yanev <[email protected]> * chore: extend tests in `validator.spec.ts` to cover `tracerConfig` type Signed-off-by: Victor Yanev <[email protected]> * chore: final touches + address comments Signed-off-by: Victor Yanev <[email protected]> * fix: build error Signed-off-by: Victor Yanev <[email protected]> * fix: allow "0x" value for BASE_HEX_REGEX Signed-off-by: Victor Yanev <[email protected]> * fix: allow ``"0x"` value for `hex` type Signed-off-by: Victor Yanev <[email protected]> * fix: allow ``"0x"` value for `hex` type Signed-off-by: Victor Yanev <[email protected]> * fix: Bug due to validations of `eth_call` Signed-off-by: Victor Yanev <[email protected]> * fix: tests after new validations for Transaction object Signed-off-by: Victor Yanev <[email protected]> --------- Signed-off-by: Victor Yanev <[email protected]> Signed-off-by: Victor Yanev <[email protected]>
Description:
This PR modifies the object validation logic in order to support the deletion of unknown properties.
deleteUnknownProperties
in object schemadeleteUnknownProperties
method if the schema property is setRelated issue(s):
Fixes #2827
Checklist