Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gas precheck to eth_sendRawTransaction #291

Merged
merged 2 commits into from
Jul 4, 2022
Merged

Conversation

ar-conmit
Copy link
Collaborator

Signed-off-by: Anton Rusev [email protected]

Description:

Related issue(s):

Fixes #127

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Anton Rusev <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #291 (4fada65) into main (25063ba) will increase coverage by 0.06%.
The diff coverage is 63.63%.

❗ Current head 4fada65 differs from pull request most recent head b7531cc. Consider uploading reports for the commit b7531cc to get more accurate results

@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
+ Coverage   58.94%   59.01%   +0.06%     
==========================================
  Files           9        9              
  Lines         760      771      +11     
  Branches      115      118       +3     
==========================================
+ Hits          448      455       +7     
- Misses        286      290       +4     
  Partials       26       26              
Impacted Files Coverage Δ
packages/relay/src/lib/errors.ts 100.00% <ø> (ø)
packages/relay/src/lib/eth.ts 57.44% <0.00%> (-0.70%) ⬇️
packages/relay/src/lib/precheck.ts 74.07% <100.00%> (+9.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25063ba...b7531cc. Read the comment docs.

@ar-conmit ar-conmit self-assigned this Jul 4, 2022
@Nana-EC Nana-EC added enhancement New feature or request limechain P2 labels Jul 4, 2022
@Nana-EC Nana-EC added this to the 0.3.0 milestone Jul 4, 2022
Signed-off-by: Anton Rusev <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jul 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@ar-conmit ar-conmit merged commit dc57c06 into main Jul 4, 2022
@ar-conmit ar-conmit deleted the 127-gas-precheck branch July 4, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request limechain P2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add gas precheck to eth_sendRawTransaction
3 participants