Add balance precheck to eth_sendRawtransaction #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Rusev <[email protected]>
Signed-off-by: Anton Rusev <[email protected]>
Nana-EC
requested changes
Jul 5, 2022
| nonce: await relay.getAccountNonce(accounts[2].address) | ||
| }; | ||
| const signedTx = await accounts[2].wallet.signTransaction(transaction); | ||
| await relay.callFailing('eth_sendRawTransaction', [signedTx], -32000, 'Insufficient funds for transfer'); |
There was a problem hiding this comment.
nit: Should pull code and error message from errors.ts itself to avoid breaking test case on changes
| const balance = await this.executeQuery(new AccountBalanceQuery() | ||
| .setAccountId(account)); | ||
|
|
||
| return ethers.BigNumber.from(balance.hbars.toTinybars().toString()).mul(10 ** 10); |
| @@ -275,6 +275,13 @@ export default class ServicesClient { | |||
| const receipt = await response.getReceipt(this.client); | |||
| this.logger.info(`File ${fileId} updated with status: ${receipt.status.toString()}`); | |||
| } | |||
|
|
|||
| async getAccountBalanceInWeiBars(account: string | AccountId) { | |||
| const balance = await this.executeQuery(new AccountBalanceQuery() | |||
There was a problem hiding this comment.
Pull out AccountBalanceQuery execution into a separate method as it's used multiple times in this class
Will need to update it to handle AccountId also
Suggested change
| const balance = await this.executeQuery(new AccountBalanceQuery() | |
| const balance = await this.getAccountBalance(account) |
e.g.
async getAccountBalance(account: string | AccountId): Promise<AccountBalance> {
return this.executeQuery(new AccountBalanceQuery()
.setAccountId(AccountId.fromString(account)), this.clientMain);
}
Signed-off-by: Anton Rusev <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
getTransactionByHashfor null value ofcontractResult.tocausing "multiple done() method invoked" error in acceptance testsjsonRpcErrorassertion to accept predefined error objectRelated issue(s):
Fixes #130
Notes for reviewer:
Checklist