Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging, metrics and error handling #297

Merged
merged 3 commits into from
Jul 6, 2022
Merged

Conversation

Nana-EC
Copy link
Collaborator

@Nana-EC Nana-EC commented Jul 6, 2022

Signed-off-by: Nana-EC [email protected]

Description:
Improve logging metrics and error handling

  • Update balance metric to show operator id
  • Fix some logging issues
  • Add api callerName to sdkClient metrics to allow for cost per API analysis
  • Fix issues around contract results revert and empty results scenarios from mirror node

Related issue(s):

Fixes #272

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@Nana-EC Nana-EC self-assigned this Jul 6, 2022
@Nana-EC Nana-EC added enhancement New feature or request P3 labels Jul 6, 2022
@Nana-EC Nana-EC added this to the 0.3.0 milestone Jul 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2022

Codecov Report

Merging #297 (67813cf) into main (b1a9155) will increase coverage by 1.45%.
The diff coverage is 45.65%.

@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
+ Coverage   56.31%   57.76%   +1.45%     
==========================================
  Files           9        9              
  Lines         824      824              
  Branches      130      131       +1     
==========================================
+ Hits          464      476      +12     
+ Misses        334      322      -12     
  Partials       26       26              
Impacted Files Coverage Δ
packages/relay/src/lib/clients/sdkClient.ts 6.93% <0.00%> (+0.62%) ⬆️
packages/relay/src/lib/precheck.ts 50.00% <0.00%> (ø)
packages/relay/src/lib/eth.ts 59.84% <70.00%> (+1.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1a9155...67813cf. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@ar-conmit ar-conmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@Nana-EC Nana-EC merged commit 75e1e60 into main Jul 6, 2022
@Nana-EC Nana-EC deleted the 272-improve-logs-metrics branch July 6, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add account_id to rpc_relay_operator_balance metric
3 participants