fix: Bumped up exchanged value #2972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fee from the value instead of the gas. Signed-off-by: ebadiere <[email protected]>
ebadiere
requested review from
AlfredoG87,
Nana-EC and
a team
as code owners
quiet-node
previously approved these changes
Sep 16, 2024
2 tasks
Co-authored-by: Luis Mastrangelo <[email protected]> Signed-off-by: Eric Badiere <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2972 +/- ##
=======================================
Coverage 89.53% 89.54%
=======================================
Files 56 56
Lines 3794 3796 +2
Branches 772 775 +3
=======================================
+ Hits 3397 3399 +2
Misses 350 350
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. |
quiet-node
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped up exchanged value as the HTS token create will take the fee from the value instead of the gas.
Description:
Related issue(s):
Fixes #2951
Notes for reviewer:
Checklist