Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Wagmi example usage with Hedera #3000

Merged
merged 7 commits into from
Oct 10, 2024
Merged

feat: Wagmi example usage with Hedera #3000

merged 7 commits into from
Oct 10, 2024

Conversation

arianejasuwienas
Copy link
Contributor

Description:
Validate wagmi support and add example usage with hedera

Related issue(s):

Implements: #2802

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@arianejasuwienas arianejasuwienas added the ArianeLabs Items ArianeLabs is contributing to label Sep 17, 2024
@arianejasuwienas arianejasuwienas added this to the 0.57.0 milestone Sep 17, 2024
@arianejasuwienas arianejasuwienas self-assigned this Sep 17, 2024
@arianejasuwienas arianejasuwienas added the enhancement New feature or request label Sep 17, 2024
Copy link

github-actions bot commented Sep 17, 2024

Acceptance Tests

  17 files  223 suites   30m 50s ⏱️
604 tests 593 ✔️ 4 💤 7
695 runs  684 ✔️ 4 💤 7

Results for commit f3eb395.

♻️ This comment has been updated with latest results.

acuarica
acuarica previously approved these changes Sep 17, 2024
Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

victor-yanev
victor-yanev previously approved these changes Sep 17, 2024
Copy link

github-actions bot commented Sep 18, 2024

Tests

       3 files     297 suites   19s ⏱️
1 353 tests 1 352 ✔️ 1 💤 0
1 362 runs  1 361 ✔️ 1 💤 0

Results for commit f3eb395.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, minor suggestions.
Also images or short video are great attachments to the PR to should the UI representation of the code since it can't be seen by just reviewing the code

tools/wagmi-example/README.md Show resolved Hide resolved
tools/wagmi-example/src/App.tsx Outdated Show resolved Hide resolved
Signed-off-by: Mariusz Jasuwienas <[email protected]>
Signed-off-by: Mariusz Jasuwienas <[email protected]>
acuarica
acuarica previously approved these changes Sep 20, 2024
Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

Nana-EC
Nana-EC previously approved these changes Sep 26, 2024
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, please share details around the solc version choice though in follow up

tools/wagmi-example/README.md Outdated Show resolved Hide resolved
… about them was no longer valid

Signed-off-by: Mariusz Jasuwienas <[email protected]>
Copy link

sonarcloud bot commented Sep 27, 2024

@ebadiere ebadiere modified the milestones: 0.57.0, 0.58.0 Sep 30, 2024
Copy link
Collaborator

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.

Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@ebadiere ebadiere merged commit 6bc6010 into main Oct 10, 2024
43 checks passed
@ebadiere ebadiere deleted the 2802-wagmi-support branch October 10, 2024 17:17
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.91%. Comparing base (265e137) to head (f3eb395).
Report is 191 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3000      +/-   ##
==========================================
+ Coverage   77.06%   84.91%   +7.85%     
==========================================
  Files          40       58      +18     
  Lines        3266     3905     +639     
  Branches      683      784     +101     
==========================================
+ Hits         2517     3316     +799     
+ Misses        529      348     -181     
- Partials      220      241      +21     
Flag Coverage Δ
relay 85.11% <ø> (?)
server 83.05% <ø> (?)
ws-server 97.87% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 50 files with indirect coverage changes

konstantinabl pushed a commit that referenced this pull request Oct 15, 2024
* feat: Wagmi example usage with Hedera

Signed-off-by: mateuszm-arianelabs <[email protected]>

* chore: typo in readme, remove unused import

Signed-off-by: mateuszm-arianelabs <[email protected]>

* chore: typo in readme, cleanup in code

Signed-off-by: mateuszm-arianelabs <[email protected]>

* chore: change pnpm to npm, small fixes

Signed-off-by: mateuszm-arianelabs <[email protected]>

* feat: pr suggestions applied

Signed-off-by: Mariusz Jasuwienas <[email protected]>

* feat: pr suggestions applied

Signed-off-by: Mariusz Jasuwienas <[email protected]>

* feat: cancuns opcodes are supported in hedera already so this comment about them was no longer valid

Signed-off-by: Mariusz Jasuwienas <[email protected]>

---------

Signed-off-by: mateuszm-arianelabs <[email protected]>
Signed-off-by: Mariusz Jasuwienas <[email protected]>
Co-authored-by: mateuszm-arianelabs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ArianeLabs Items ArianeLabs is contributing to enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants