Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hardcoded chainId in acceptance tests #3010

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

victor-yanev
Copy link
Contributor

Description:

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@victor-yanev victor-yanev self-assigned this Sep 18, 2024
@victor-yanev victor-yanev added the bug Something isn't working label Sep 18, 2024
@victor-yanev victor-yanev added this to the 0.57.0 milestone Sep 18, 2024
Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
43.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

Acceptance Tests

  17 files  219 suites   29m 21s ⏱️
605 tests 600 ✔️ 4 💤 1
620 runs  615 ✔️ 4 💤 1

Results for commit cebc4da.

Copy link

Tests

       3 files     297 suites   19s ⏱️
1 353 tests 1 352 ✔️ 1 💤 0
1 362 runs  1 361 ✔️ 1 💤 0

Results for commit cebc4da.

@victor-yanev victor-yanev merged commit f6f1220 into main Sep 19, 2024
40 of 41 checks passed
@victor-yanev victor-yanev deleted the fix-wrong-chainId-in-acceptance-tests branch September 19, 2024 11:44
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.54%. Comparing base (b160863) to head (cebc4da).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3010      +/-   ##
==========================================
+ Coverage   88.33%   89.54%   +1.20%     
==========================================
  Files          61       61              
  Lines        4054     4054              
  Branches      815      815              
==========================================
+ Hits         3581     3630      +49     
+ Misses        430      383      -47     
+ Partials       43       41       -2     
Flag Coverage Δ
relay 90.14% <ø> (ø)
server 88.15% <ø> (ø)
ws-server 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants