Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added configuration option for allocating HBar for a test run. #3013

Merged
merged 6 commits into from
Sep 30, 2024

Conversation

ebadiere
Copy link
Collaborator

Added configuration option for HBar required in the relay operator balance to run a given test suite

Fixes #3007

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ebadiere ebadiere added the enhancement New feature or request label Sep 18, 2024
@ebadiere ebadiere added this to the 0.57.0 milestone Sep 18, 2024
@ebadiere ebadiere self-assigned this Sep 18, 2024
Copy link

github-actions bot commented Sep 18, 2024

Tests

       3 files     297 suites   19s ⏱️
1 353 tests 1 352 ✔️ 1 💤 0
1 362 runs  1 361 ✔️ 1 💤 0

Results for commit 8a072f7.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Sep 18, 2024

Acceptance Tests

  18 files  253 suites   31m 55s ⏱️
608 tests 596 ✔️ 4 💤 8
758 runs  746 ✔️ 4 💤 8

Results for commit 8a072f7.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion for naming and explanation

docs/configuration.md Outdated Show resolved Hide resolved
Co-authored-by: Nana Essilfie-Conduah <[email protected]>
Signed-off-by: Eric Badiere <[email protected]>
Nana-EC
Nana-EC previously approved these changes Sep 18, 2024
packages/server/tests/acceptance/index.spec.ts Outdated Show resolved Hide resolved
Copy link

🚨 Memory Leak Detected 🚨

A potential memory leak has been detected in the test titled should execute "eth_getTransactionByHash with missing transaction". This may impact the application's performance and stability.

Details

📊 Memory Leak Detection Report 📊

GC Type: MarkSweepCompact
Cost: 32,703.7 ms

Heap Statistics (before vs after executing the test):

  • Total Heap Size: increased with 1.05 MB
  • Total Heap Size Executable: no changes
  • Total Physical Size: increased with 1.05 MB
  • Total Available Size: decreased with 2.26 MB
  • Total Global Handles Size: no changes
  • Used Global Handles Size: decreased with 128.00 bytes
  • Used Heap Size: decreased with 2.53 MB
  • Heap Size Limit: no changes
  • Malloced Memory: no changes
  • External Memory: no changes
  • Peak Malloced Memory: no changes

Heap Space Statistics (before vs after executing the test):

  • Old Space:
    • Space Size: increased with 1.05 MB
    • Space Used Size: increased with 584.98 KB
    • Space Available Size: decreased with 3.07 MB
    • Physical Space Size: increased with 1.05 MB

Recommendations

Please investigate the memory allocations in this test, focusing on objects that are not being properly deallocated.

Copy link

sonarcloud bot commented Sep 30, 2024

@ebadiere ebadiere merged commit 4cdf8ae into main Sep 30, 2024
43 checks passed
@ebadiere ebadiere deleted the 3007-configure-test-balance branch September 30, 2024 16:04
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.91%. Comparing base (e37dcef) to head (8a072f7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3013   +/-   ##
=======================================
  Coverage   84.91%   84.91%           
=======================================
  Files          58       58           
  Lines        3905     3905           
  Branches      784      784           
=======================================
  Hits         3316     3316           
  Misses        348      348           
  Partials      241      241           
Flag Coverage Δ
relay 85.11% <ø> (ø)
server 83.05% <ø> (ø)
ws-server 97.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Configure the test balance to be variable when running the acceptance test suite.
4 participants