Implement gasLimit Precheck #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mitchell Martin <[email protected]>
Signed-off-by: Mitchell Martin <[email protected]>
# Conflicts: # packages/relay/src/lib/errors.ts # packages/relay/src/lib/precheck.ts
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
# Conflicts: # packages/relay/src/lib/errors.ts # packages/relay/tests/lib/precheck.spec.ts # packages/server/tests/acceptance/rpc.spec.ts
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
# Conflicts: # packages/relay/src/lib/eth.ts # packages/relay/src/lib/precheck.ts # packages/relay/tests/lib/precheck.spec.ts # packages/server/tests/acceptance/rpc.spec.ts
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
# Conflicts: # packages/relay/src/lib/eth.ts
Signed-off-by: Mitchell Martin <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Nana-EC <[email protected]>
Signed-off-by: Nana-EC <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #304 +/- ##
==========================================
+ Coverage 57.84% 58.29% +0.45%
==========================================
Files 9 9
Lines 835 856 +21
Branches 135 139 +4
==========================================
+ Hits 483 499 +16
- Misses 322 325 +3
- Partials 30 32 +2
Continue to review full report at Codecov.
|
Nana-EC
previously approved these changes
Jul 7, 2022
…gasLimit-precheck # Conflicts: # packages/relay/src/lib/constants.ts # packages/relay/src/lib/precheck.ts # packages/relay/tests/lib/precheck.spec.ts
Signed-off-by: Ivo Yankov <[email protected]>
# Conflicts: # packages/relay/src/lib/constants.ts # packages/server/tests/acceptance/rpc.spec.ts
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Ivo-Yankov
commented
Jul 8, 2022
| } | ||
| } | ||
|
|
||
| const nonZeros = data.replace('0x', '').length - zeros; |
There was a problem hiding this comment.
This was causing a wrong calculation of the gas cost. If 0x is not removed from data, that counts as 2 nonZero bytes, and the calculated gas cost is TX_BASE_COST + 2 * ISTANBUL_TX_DATA_NON_ZERO_COST, which meant that transactions with empty data (hbar transfer transactions) could not pass the precheck if the default gasLimit (21000) was used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Implements gasLimit over/under checks before submitting in sendRawTransactions
Related issue(s):
Fixes #128
Notes for reviewer:
Checklist