Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add release testing workflow for public networks #3060

Merged
merged 2 commits into from
Oct 9, 2024
Merged

feat: Add release testing workflow for public networks #3060

merged 2 commits into from
Oct 9, 2024

Conversation

beeradb
Copy link
Contributor

@beeradb beeradb commented Oct 3, 2024 •
edited by ebadiere
Loading

This PR refactors the public acceptance workflow to do the following:

  • Adds support for mainnet
  • Run only the "release_tests" tag against public networks.
  • Use the new TEST_INITIAL_ACCOUNT_STARTING_BALANCE attribute to ensure tests will allow runs with only 500 hbar in the operator account.
  • Provide configurations for mainnet environment.

Fixes: #2947

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024 •
edited
Loading

Tests

       3 files     297 suites   19s ⏱️
1 353 tests 1 352 ✔️ 1 💤 0 ❌
1 362 runs  1 361 ✔️ 1 💤 0 ❌

Results for commit 8e523d5.

♻️ This comment has been updated with latest results.

@beeradb beeradb changed the title Add release testing workflow for public networks [feat] Add release testing workflow for public networks Oct 3, 2024
@beeradb beeradb changed the title [feat] Add release testing workflow for public networks feat: Add release testing workflow for public networks Oct 3, 2024
@beeradb beeradb added this to the 0.58.0 milestone Oct 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024 •
edited
Loading

Acceptance Tests

  19 files  236 suites   31m 4s ⏱️
604 tests 596 ✔️ 4 💤 4 ❌
689 runs  680 ✔️ 5 💤 4 ❌

Results for commit 8e523d5.

♻️ This comment has been updated with latest results.

@quiet-node quiet-node added the enhancement New feature or request label Oct 4, 2024
ebadiere
ebadiere reviewed Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, but Logan's question about chainId should be resolved.

@beeradb
Update CHAIN_ID
8e523d5 
Signed-off-by: beeradb <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ebadiere ebadiere self-requested a review October 9, 2024 22:48
ebadiere
ebadiere approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.

@ebadiere ebadiere merged commit 1c65943 into main Oct 9, 2024
45 checks passed
@ebadiere ebadiere deleted the acceptance-test-public branch October 9, 2024 22:51
@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.83%. Comparing base (f1794d8) to head (8e523d5).
Report is 12 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3060   +/-   ##
=======================================
  Coverage   84.83%   84.83%           
=======================================
  Files          59       59           
  Lines        3937     3937           
  Branches      786      786           
=======================================
  Hits         3340     3340           
  Misses        357      357           
  Partials      240      240
Flag Coverage Δ
relay 84.94% <ø> (ø)
server 83.43% <ø> (ø)
ws-server 97.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

konstantinabl pushed a commit that referenced this pull request Oct 15, 2024
@beeradb @konstantinabl
feat: Add release testing workflow for public networks (#3060)
9958292 
* Add public acceptance tests workflow

Signed-off-by: beeradb <[email protected]>

* Update CHAIN_ID

Signed-off-by: beeradb <[email protected]>

---------

Signed-off-by: beeradb <[email protected]>
@quiet-node quiet-node removed the enhancement New feature or request label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebadiere ebadiere ebadiere approved these changes

@quiet-node quiet-node quiet-node approved these changes

@AlfredoG87 AlfredoG87 Awaiting requested review from AlfredoG87 AlfredoG87 is a code owner

@Nana-EC Nana-EC Awaiting requested review from Nana-EC Nana-EC is a code owner

@JeffreyDallas JeffreyDallas Awaiting requested review from JeffreyDallas JeffreyDallas is a code owner automatically assigned from hashgraph/release-engineering

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy is a code owner automatically assigned from hashgraph/release-engineering-managers

Assignees

@beeradb beeradb

Labels
github_actions
Projects
None yet
Milestone
0.58.0
Development

Successfully merging this pull request may close these issues.

Create CI workflow to run a post release test suite on mainnet
3 participants
@beeradb @ebadiere @quiet-node