-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added newFilter to paramRearrangementMap for WS server #3117
Conversation
Signed-off-by: Logan Nguyen <[email protected]>
🚨 Memory Leak Detected 🚨A potential memory leak has been detected in the test titled Details📊 Memory Leak Detection Report 📊 GC Type: MarkSweepCompact Heap Statistics (before vs after executing the test):
Heap Space Statistics (before vs after executing the test):
RecommendationsPlease investigate the memory allocations in this test, focusing on objects that are not being properly deallocated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but needs tests
Signed-off-by: Logan Nguyen <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3117 +/- ##
==========================================
- Coverage 85.53% 83.46% -2.08%
==========================================
Files 45 66 +21
Lines 3387 4402 +1015
Branches 673 868 +195
==========================================
+ Hits 2897 3674 +777
- Misses 282 459 +177
- Partials 208 269 +61
Flags with carried forward coverage won't be shown. Click here to find out more.
|
* fix: added newFilter to paramRearrangementMap for WS server Signed-off-by: Logan Nguyen <[email protected]> * test: added unit test Signed-off-by: Logan Nguyen <[email protected]> --------- Signed-off-by: Logan Nguyen <[email protected]>
Description:
There's a regression in the WS server that breaks the
eth_newFilter
WS endpoint. Essentially, before the data is submitted to the Relay, there’s a step to rearrange the parameters for certain special endpoints that have a different parameter order than others. This step is handled by theparamRearrangementMap
, but it missed thenewFilter
endpoint, so the parameters weren't ordered correctly, causing theeth_newFilter
endpoint to fail.This PR simply adds the
newFilter
method to theparamRearrangementMap
, fixing the issue.Related issue(s):
Fixes #3114
Notes for reviewer:
Checklist