Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardhat relay compatibility #334

Merged
merged 6 commits into from
Jul 14, 2022
Merged

Hardhat relay compatibility #334

merged 6 commits into from
Jul 14, 2022

Conversation

natanasow
Copy link
Collaborator

@natanasow natanasow commented Jul 13, 2022 •
edited by Nana-EC
Loading

Signed-off-by: nikolay [email protected]

Description:

Related issue(s):

Fixes #311

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@natanasow natanasow marked this pull request as draft July 13, 2022 06:48
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2022 •
edited
Loading

Codecov Report

Merging #334 (8c26b8c) into main (73d8244) will not change coverage.
The diff coverage is n/a.

❗ Current head 8c26b8c differs from pull request most recent head 89969fe. Consider uploading reports for the commit 89969fe to get more accurate results

@@           Coverage Diff           @@
##             main     #334   +/-   ##
=======================================
  Coverage   62.44%   62.44%           
=======================================
  Files           9        9           
  Lines         868      868           
  Branches      141      141           
=======================================
  Hits          542      542           
  Misses        288      288           
  Partials       38       38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d8244...89969fe. Read the comment docs.

@natanasow
Add readme
cdee816 
Signed-off-by: nikolay <[email protected]>
@natanasow
Fix code smells
fcdcddf 
Signed-off-by: nikolay <[email protected]>
Nana-EC
Nana-EC requested changes Jul 13, 2022
View reviewed changes
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.
Some early comments

hardhat-example/README.md Outdated Show resolved Hide resolved
hardhat-example/README.md Outdated Show resolved Hide resolved
hardhat-example/scripts/contractCall.js Outdated Show resolved Hide resolved
hardhat-example/scripts/deployContract.js Outdated Show resolved Hide resolved
hardhat-example/scripts/transferHbars.js Outdated Show resolved Hide resolved
hardhat-example/scripts/transferHbars.js Outdated Show resolved Hide resolved
hardhat-example/scripts/transferHbars.js Outdated Show resolved Hide resolved
@natanasow natanasow marked this pull request as ready for review July 13, 2022 16:27
@natanasow natanasow requested a review from Nana-EC July 13, 2022 16:27
Nana-EC
Nana-EC requested changes Jul 13, 2022
View reviewed changes
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.
License header and nit number format and this is good to go

tools/hardhat-example/scripts/contractCall.js Show resolved Hide resolved
tools/hardhat-example/scripts/transferHbars.js Outdated Show resolved Hide resolved
tools/hardhat-example/scripts/transferHbars.js Outdated Show resolved Hide resolved
@natanasow
Add license headers
89969fe 
Signed-off-by: nikolay <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jul 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@natanasow natanasow requested a review from Nana-EC July 14, 2022 08:05
Nana-EC
Nana-EC approved these changes Jul 14, 2022
View reviewed changes
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@Nana-EC Nana-EC added enhancement New feature or request limechain P1 dev tools Features enabling dev tool integration labels Jul 14, 2022
@natanasow natanasow merged commit 637d3af into main Jul 14, 2022
@natanasow natanasow deleted the 311-hardhat-relay-compatibility branch July 14, 2022 15:28
@Nana-EC Nana-EC added this to the 0.4.0 milestone Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nana-EC Nana-EC Nana-EC approved these changes

Assignees

@natanasow natanasow

Labels
dev tools Features enabling dev tool integration enhancement New feature or request limechain P1
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

Hardhat <> relay compatibility
3 participants
@natanasow @codecov-commenter @Nana-EC