Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate per-partition service endpoint metadata #1182

Merged
merged 6 commits into from
Sep 23, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Sep 23, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Add generated per-partition service endpoint metadata to the top-level endpoints package.
Required for migration of the Terraform AWS Provider's aws_service data source away from the AWS SDK for Go v1.

Relates #1176.

% go test ./...
?   	github.com/hashicorp/aws-sdk-go-base/v2/configtesting	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/awsconfig	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/constants	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/errs	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/generate/common	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/slices	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/test	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/mockdata	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/servicemocks	[no test files]
ok  	github.com/hashicorp/aws-sdk-go-base/v2	16.756s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/diag	1.304s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/endpoints	0.834s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/internal/config	0.866s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/internal/expand	0.649s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/logging	1.466s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/tfawserr	1.115s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/useragent	1.469s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/validation	1.578s

@ewbankkit ewbankkit requested a review from a team as a code owner September 23, 2024 13:29
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

endpoints/service.go Outdated Show resolved Hide resolved
internal/generate/endpoints/main.go Outdated Show resolved Hide resolved
@ewbankkit ewbankkit merged commit e6becd9 into main Sep 23, 2024
12 checks passed
@ewbankkit ewbankkit deleted the f-generate-partitions-services branch September 23, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants