Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: blurry svgs in safari #2507

Merged
merged 10 commits into from
Jul 15, 2024
Merged

fix: blurry svgs in safari #2507

merged 10 commits into from
Jul 15, 2024

Conversation

LeahMarieBush
Copy link
Contributor

@LeahMarieBush LeahMarieBush commented Jul 9, 2024 •
edited
Loading

🔗 Relevant links

🗒️ What

This PR updates the try-hcp-callout side image to use the svg inline vs as the background image. This is due to a bug in safari where the svgs look blurry. This PR fixes that issue and also another issue where svg ids are being duplicated (more context here)

📸 Design Screenshots

Before
Screenshot 2024-07-09 at 3 18 37 PM

After
Screenshot 2024-07-09 at 3 18 20 PM

🧪 Testing

  1. Go to safari with the preview link
  2. Look at the try-hcp-callout component on the page
  3. Note that it is no longer blurry.
  4. Also go to other product landing pages and make sure those images aren't blurry as well.

@vercel Vercel
Copy link

vercel bot commented Jul 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 8:40pm

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

@LeahMarieBush LeahMarieBush mentioned this pull request Jul 9, 2024
Merged
4 tasks
@LeahMarieBush LeahMarieBush marked this pull request as ready for review July 9, 2024 20:19
@LeahMarieBush LeahMarieBush requested review from a team and nandereck and removed request for a team July 9, 2024 20:56
nandereck
nandereck reviewed Jul 10, 2024
View reviewed changes
Copy link
Contributor

@nandereck nandereck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to address the issue but have some clarification questions related to the package update and the bundle size!

package.json Show resolved Hide resolved
src/components/try-hcp-callout/content.ts Outdated Show resolved Hide resolved
nandereck
nandereck approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@nandereck nandereck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥇 Awesome work!

Mind removing the note about the bundle size in your PR description before merging?

@LeahMarieBush LeahMarieBush merged commit beff95f into main Jul 15, 2024
9 checks passed
@LeahMarieBush LeahMarieBush deleted the leah/fix/blurry-svgs-safari branch July 15, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nandereck nandereck nandereck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeahMarieBush @nandereck