Allow configuring an alternative logger #116
Conversation
DanStough
force-pushed
the
allow-specifying-a-logger
branch
2 times, most recently
from
7b621be
to
c296d9b
Compare
client.go
Outdated
| @@ -49,6 +49,7 @@ type QueryParam struct { | |||
| WantUnicastResponse bool // Unicast response desired, as per 5.4 in RFC | |||
| DisableIPv4 bool // Whether to disable usage of IPv4 for MDNS operations. Does not affect discovered addresses. | |||
| DisableIPv6 bool // Whether to disable usage of IPv6 for MDNS operations. Does not affect discovered addresses. | |||
| Log *log.Logger // Optionally provide a *log.Logger to better manage log output. | |||
There was a problem hiding this comment.
Why Log here and Logger on the other exported struct field. I think we typically name these sorts of optional config fields Logger over in serf & memberlist support libraries.
|
Are there any plans for merging this PR anytime soon? It would be much appreciated. Thanks. |
|
@jcodybaker do you want to make the suggested change from |
|
Sorry for the delay on merging here. This was for a personal project and the day job got busy. Thanks for the rebase and review. @DanStough feel free to merge on reapproval. |
|
@DanStough I have tested the changes locally and the log gets rerouted as expected 👍 Would be awsome if this PR could be merged in the near future. |
|
Thank you all! |
This PR provides a backwards compatible way to manage logout by providing a *log.Logger in Client and Server config. If one is not specified, client and server will fall back to the original behavior and use the default log.Default() logger.
Integrators can plumb the output to a custom log sink by creating a new *log.Logger with a customer io.Writer. They can also disable logging by by creating a *log.Logger with the io.Discard writer.