Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent a nil pointer dereference segfault #120

Merged

Commits on Apr 19, 2024

  1. Prevent a nil pointer dereference segfault

    A nil pointer dereference segfault may occur when [ipv4, ipv6].NewPacketConn() is called with an argument that is nil. The four arguments to the four calls to NewPacketConn() may be nil if the functions that set them, inside the newClient() function, return a non-nil error.
    
    In newClient() there are two calls to net.ListenUDP that set uconn4 and uconn6, and two calls to net.ListenMulticastUDP that set mconn4 and mconn6. There are network scenarios where multicast may be allowed for IPv4 addresses, but not IPv6 addresses, for example. In this case the check in newClient() that returns an error, (if mconn4 == nil && mconn6 == nil), is not hit because only mconn6 is nil. Then, ipv6MulticastConn is set to nil in the returned client object. This nil value for ipv6MulticastConn is then used as an argument to ipv6.NewPacketConn in setInterface() and a nil pointer dereference segfault occurs.
    
    This PR prevents the segfault by checking that each protocol (IPv4 and IPv6) has both unicast and multicast connections. If either unicast or multicast is not present for a protocol, then both are disabled and the `use_ipv[4, 6]` flag is set to false.
    boydjeff committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    023c8e1 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Apply suggestions from code review

    Co-authored-by: Dan Stough <[email protected]>
    boydjeff and DanStough authored May 3, 2024
    Configuration menu
    Copy the full SHA
    7c6a612 View commit details
    Browse the repository at this point in the history