Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart task's that uses secrets that rendered throw consultemplate when nomad client restarts #6324

Conversation

tantra35
Copy link
Contributor

This pull request was created as replacement for #6059

This PR try solve problem which described in #4226

This is a second our try to push this in nomad mainline, first was declined due huge code changes between 0.8.x and 0.9.x

The key idea of this patch is, in fact that consul-template doesn't persisted it state between nomad agent restarts(for example systemctl restart nomad) and regenerate dynamic secrets(for example https://www.vaultproject.io/docs/secrets/aws/index.html) but in case of restart nomad doesn't inform about this fact tasks(this happens only when agent restarts), and there can be situations when secrets already revoked by vault, but task still running

Some remarks from @nickethier (from #6059) we will fix, after some times

Sorry for our mistake in git branches management :-(

@tgross
Copy link
Member

tgross commented Dec 10, 2020

Closing this PR in lieu of the approach described in #9491 (comment). Sorry this sat around so long unreviewed... we knew it wasn't quite how we wanted to do it but we didn't manage to get resources on the issue to resolve it. I'm working that one now.

@github-actions
Copy link

github-actions bot commented Dec 6, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants