Unit tests, go mod tidy

hashicorp · Aug 10, 2023 · 2dc1edb · 2dc1edb
1 parent b31ebca
commit 2dc1edb
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 1 deletion.
diff --git a/internal/flex/flex.go b/internal/flex/flex.go
@@ -31,7 +31,7 @@ func ExpandStringList(configured []interface{}) []*string {
 }
 
 // ExpandStringListEmpty the result of flatmap. Expand for an array of strings
-// and returns a []*string. Empty strings are NOT skipped.
+// and returns a []*string. Adds an empty element for every nil or uncastable.
 func ExpandStringListEmpty(configured []interface{}) []*string {
  vs := make([]*string, 0, len(configured))
  for _, v := range configured {

diff --git a/internal/flex/flex_test.go b/internal/flex/flex_test.go
@@ -39,6 +39,37 @@ func TestExpandStringList(t *testing.T) {
  }
 }
 
+func TestExpandStringListEmpty(t *testing.T) {
+ t.Parallel()
+
+ testCases := []struct {
+ configured []interface{}
+ want []*string
+ }{
+ {
+ configured: []interface{}{"abc", "xyz123"},
+ want: []*string{aws.String("abc"), aws.String("xyz123")},
+ },
+ {
+ configured: []interface{}{"abc", 123, "xyz123"},
+ want: []*string{aws.String("abc"), aws.String(""), aws.String("xyz123")},
+ },
+ {
+ configured: []interface{}{"foo", "bar", "", "baz"},
+ want: []*string{aws.String("foo"), aws.String("bar"), aws.String(""), aws.String("baz")},
+ },
+ {
+ configured: []interface{}{"foo", "bar", nil, "baz"},
+ want: []*string{aws.String("foo"), aws.String("bar"), aws.String(""), aws.String("baz")},
+ },
+ }
+ for _, testCase := range testCases {
+ if got, want := ExpandStringListEmpty(testCase.configured), testCase.want; !cmp.Equal(got, want) {
+ t.Errorf("ExpandStringListEmpty(%v) = %v, want %v", testCase.configured, got, want)
+ }
+ }
+}
+
 func TestExpandStringTimeList(t *testing.T) {
  t.Parallel()